Skip to content

Conversation

zeripath
Copy link
Contributor

Sets maximum width for the review-box comment boxes

Fix #10338

@zeripath zeripath added type/bug topic/ui Change the appearance of the Gitea UI backport/v1.11 labels Feb 18, 2020
@zeripath zeripath added this to the 1.12.0 milestone Feb 18, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 18, 2020
Copy link
Member

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we start to add more media queries I think we should do something like #10301 (comment) sooner than later, but for the time being LGTM

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 18, 2020
@codecov-io
Copy link

codecov-io commented Feb 18, 2020

Codecov Report

Merging #10348 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10348      +/-   ##
==========================================
- Coverage   43.73%   43.71%   -0.02%     
==========================================
  Files         585      585              
  Lines       81019    81019              
==========================================
- Hits        35430    35419      -11     
- Misses      41205    41213       +8     
- Partials     4384     4387       +3
Impacted Files Coverage Δ
modules/process/manager.go 74.69% <0%> (-3.62%) ⬇️
services/pull/temp_repo.go 31.62% <0%> (-2.57%) ⬇️
models/notification.go 64.13% <0%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ca9be1...c3b24a9. Read the comment docs.

@zeripath zeripath merged commit 9f1f2e6 into go-gitea:master Feb 18, 2020
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Feb 19, 2020
jolheiser pushed a commit that referenced this pull request Feb 19, 2020
@jolheiser jolheiser added the backport/done All backports for this PR have been created label Feb 19, 2020
@zeripath zeripath deleted the fix-10338-set-max-width-on-review-box branch February 19, 2020 11:20
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long lines in review editor cause the window width to go past the screen edge
5 participants